Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default exceptions for MagicNumberCheck do not contain unsigned values #542

Closed
jens-auer opened this issue Jun 30, 2015 · 2 comments
Closed

Default exceptions for MagicNumberCheck do not contain unsigned values #542

jens-auer opened this issue Jun 30, 2015 · 2 comments
Assignees
@guwirth
Labels
enhancement
Milestone
M 0.9.4

Comments

@jens-auer
Copy link

The default exceptions for MagicNumberCheck define 0 and 1 in integer and floating point formats, but not for unsigned integer values. The list "0,1,0x0,0x00,.0,.1,0.0,1.0" should be extended to "0,1,0x0,0x00,.0,.1,0.0,1.0,0u,1u,0ul,1ul,1.0f, 0.0f,0LL,1LL,0ULL,1ULL".
@guwirth
Copy link
Collaborator

guwirth commented Jun 30, 2015

Makes sense. Nevertheless this setting is only the default. You can overwrite it.

@guwirth guwirth added this to the M 0.9.4 milestone Jul 1, 2015
@guwirth guwirth self-assigned this Jul 1, 2015
@guwirth
Copy link
Collaborator

guwirth commented Jul 1, 2015

see #541

@guwirth guwirth closed this as completed Jul 3, 2015
@guwirth guwirth mentioned this issue Oct 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guwirth guwirth

Labels
enhancement
Milestone
M 0.9.4
Development

No branches or pull requests
2 participants
@guwirth @jens-auer