-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of default values for the sonar.cxx.<reportsource>.reportPath #331
Comments
Don't understand the problem? |
It is a usability improvement. The plugin would be easier to use if there would be a warning in the logs in case one gets the pattern in e.g. "sonar.cxx.cppcheck.reportPath" wrong. Its not the case now, because there is a default value, for cppcheck it is: private static final String DEFAULT_REPORT_PATH = "cppcheck-reports/cppcheck-result-*.xml"; |
@wenns does this mean only removing the defaults or do we have to add also checks/warnings? |
I think this task is composed of following smaller ones:
That way, we have (somewhat) smaller logs, a little bit less code, (somewhat) better running times and better usability because of the warnings. |
I consider those values to be of no real help, introducing them was probably a dumb idea. Also, once we have no default values anymore, we could print warnings into the log if a value is set and yields no files, which is valuable user feedback.
The text was updated successfully, but these errors were encountered: