Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: cleanup CxxSquidSensor - remove getJsonCompilationDatabaseFile #1326

Closed
guwirth opened this issue Nov 20, 2017 · 0 comments · Fixed by #1970
Closed

Refactoring: cleanup CxxSquidSensor - remove getJsonCompilationDatabaseFile #1326

guwirth opened this issue Nov 20, 2017 · 0 comments · Fixed by #1970
Assignees
@guwirth
Labels
enhancement
Milestone
2.0.0

Comments

@guwirth
Copy link
Collaborator

guwirth commented Nov 20, 2017

Remove getJsonCompilationDatabaseFile call from CxxSquidSensor: cxxConf.getJsonCompilationDatabaseFile in createConfiguration.

This is slowing down the plugin because CxxSquidSensor is called for each source file. getJsonCompilationDatabaseFile should be called only once and save parsed setting at a central place e.g. CxxConfiguration.

see also #1325
@guwirth guwirth added this to the 0.9.9 milestone Nov 20, 2017
@guwirth guwirth mentioned this issue Dec 27, 2017
Closed
@guwirth guwirth modified the milestones: 0.9.9, next Jan 1, 2018
@guwirth guwirth removed this from the next milestone Jan 16, 2018
@guwirth guwirth mentioned this issue Jan 12, 2019
Merged
@guwirth guwirth added this to the 2.0.0 milestone Jun 6, 2020
@guwirth guwirth self-assigned this Oct 20, 2020
@guwirth guwirth mentioned this issue Nov 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guwirth guwirth

Labels
enhancement
Milestone
2.0.0
1 participant
@guwirth