Mathjax and backticks

[dmenne]

This was reported before in getgrav/grav#929, but proved to be an issue only when mathjax plugin is activated.

Grav 1.1.0 rc3, Plugin Mathjax 1.40

Sample code, simplified from Rcmd (R + knitr) comes in separate zip file because is shows problems with code blocks.
There seems to be a problem when there are 2 code blocks. Grav generates the following wrong output (if we accept that Catalina should be Catilina):

MarkdownPad and knitr produce correct output:

Looks like some greedy regexps involved trying to catch the last backticks.....

item.zip

Gruß von TÜ nach TÜ

[Sommerregen]

Hi @dmenne ,

you are right the regexp is to greedy and as I can see this plugin only works with Grav v0.1.0- for now. I need to rewrite this plugin a bit using Grav features, which got recently added to core. Will see what I can; I have to prioritize some things. Do you need the fix of this plugin immediately or can I think about in the next week?

[dmenne]

No hurry. The people who read this

http://menne-biomed.de/blog/multiple-indexes-stan

can read latex.

[dmenne]

Any chance?

[Sommerregen]

Yes. I've come up something with this. But time is limited. You must wait for it a little longer. Sorry.

[Sommerregen]

Hi @dmenne ,

I just updated a pre-release version in the develop branch. In order to use and install this plugin you now need Grav v1.1.0+. Switch to the the testing release and install Mathjax v1.5.0-beta.1.

If you experience any further bugs, please add a comment to this thread.

Best,
Sommerregen

[dmenne]

Looks great! Thanks for your work

Greatings from another Neckarschachtel

[dmenne]

Sorry to reopen this. On my local server, everything was perfect. On my remote server, with same IIS configuration, same php 7.0, on activating mathjax I get an error on all pages (not only those with mathjax)

and the following in the log:
grav.txt

[dmenne]

I believe you forgot to test the case when there is no formula on a page. Checking for hashes corrects that; line 222, classes/mathjax.php

    public function normalize($content, $type = 'html')
    {
        if (is_null($this->hashes))  return $content; // Added DM
        $hashes = array_keys($this->hashes);
        $text = array_column(array_values($this->hashes), $type);

[Sommerregen]

@dmenne You are totally right! I haven' tested this case. However initializinghashes in the correct way Mathjax.php, L40 via

protected $hashes = [];

should solve that problem, too. You can test it and report back. I'll work on the code and improve it a bit more.

[dmenne]

Works.

[Sommerregen]

@dmenne FYI I made a new release and some further small changes in the develop branch (the latter can be downloaded only via GitHub). Please read the changelog before updating. There is one breaking change. Don't know if it touches you.

[dmenne]

Not tested thoroughly, but looks ok.

http://menne-biomed.de/blog/multiple-indexes-stan

[Sommerregen]

@dmenne Ok, thanks! Released stable version MathJax v1.5.0 today.