-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: break to 2 apis - decrypt and encrypt #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerlh
force-pushed
the
auth-encrypt
branch
2 times, most recently
from
December 19, 2018 20:57
d895fcc
to
f51618a
Compare
shaikatz
reviewed
Dec 23, 2018
cli/encrypt.js
Outdated
|
||
var headers = { | ||
'User-Agent': 'kamus-cli', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it worth adding the version here?
shaikatz
reviewed
Dec 23, 2018
cli/index.js
Outdated
@@ -14,6 +14,7 @@ prog | |||
.option('--auth-application <id>', 'Azure application id', regexGuid) | |||
.option('--auth-resource <name>', 'Azure resource name', prog.STRING) | |||
.option('--kamus-url <url>', 'Kamus URL', prog.REQUIRED) | |||
.option('--allow-insecure-url', 'Allow insecure (http) Kamus URL', prog.BOOL); | |||
.option('--allow-insecure-url', 'Allow insecure (http) Kamus URL', prog.BOOL) | |||
.option('--cert-fingerprint <certFingerprint>', 'Force server certificate to match the givven fingerprint', prog.STRING); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typ in giveen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.