Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update Stylesheet with fonts used in the project #131

Open
thedc89 opened this issue Jul 21, 2019 · 0 comments
Open

[Enhancement] Update Stylesheet with fonts used in the project #131

thedc89 opened this issue Jul 21, 2019 · 0 comments

Comments

@thedc89
Copy link
Contributor

thedc89 commented Jul 21, 2019

To help improve clarity and make the codebase cleaner, all fonts defined in various classes should go to the Stylesheet.swift file.

Example:

titleLabel.font = UIFont(name: "Roboto-Bold", size: UIView.getValueScaledByScreenWidthFor(baseValue: 17))

should be defined in the Stylesheet as follows:

enum FontStyles {
    static let headerTitle = UIFont(name: "Roboto-Bold", size: UIView.getValueScaledByScreenWidthFor(baseValue: 17))
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant