Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extract combined comment #198

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

ariansobczak-rst
Copy link
Contributor

@ariansobczak-rst ariansobczak-rst commented Feb 10, 2022

There was an issue after upgrade typescript that combined comment e.g. with @link tag was parsed to [object Object] instead of comment block. The bug was found by test parses type 6: joined by && types

Before

/**
 * Some comment
 * @typedef {object} RecordActionAPIParams
 * @property {string} recordId   [object Object],[object Object]
 */

After

/**
 * Some comment
 * @typedef {object} RecordActionAPIParams
 * @property {string} recordId   Id of a record taken from {@link RecordJSON}
 */

@ariansobczak-rst ariansobczak-rst changed the title fix: fixed extract combined comment Fixed extract combined comment Feb 10, 2022
@ariansobczak-rst ariansobczak-rst merged commit 898f3e2 into master Feb 10, 2022
github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
## [2.7.2](v2.7.1...v2.7.2) (2022-02-10)

### Bug Fixes

* fixed extract  combined comment ([#198](#198)) ([898f3e2](898f3e2))
@github-actions
Copy link

🎉 This PR is included in version 2.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ariansobczak-rst ariansobczak-rst deleted the fix/typescript-object-comment branch March 10, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants