Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Delete action guard show "modal-subTitle" #1713

Open
Physium opened this issue Oct 14, 2024 · 3 comments
Open

[Bug]: Delete action guard show "modal-subTitle" #1713

Physium opened this issue Oct 14, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Physium
Copy link

Physium commented Oct 14, 2024

Contact Details

No response

What happened?

As reference in this comment here: 3a3961c#commitcomment-146217694

Documentation lacks any explanation on how to configure this "modal-subTitle" and even so it seems un-configurable when tracing the code back to build-action-click-handler.js.

It seems to me that the default translations were missed out the list here, adding modal-subTitle with a value of sort fixes this.

Bug prevalence

Everytime

AdminJS dependencies version

adminjs 7.8.12

What browsers do you see the problem on?

No response

Relevant log output

No response

Relevant code that's giving you issues

No response

@Physium Physium added the bug Something isn't working label Oct 14, 2024
@malteamlimit
Copy link

Thanks for opening the issue. Like I mentioned slightly in the comment - would be nice to have an option to configure the submodal message by passing an accordingly parameter. 'guard' doesn't seem to cover this entirely.

@wtime
Copy link

wtime commented Nov 9, 2024

@dziraf the subtitle property in modalProps is missing

if (actionHasDisabledComponent(action)) {
if (action.guard) {
const modalData: ModalData = {
modalProps: {
variant: 'danger',
label: 'confirm',
title: action.guard,
},
type: 'confirm',
resourceId: params.resourceId,
confirmAction: callApi,
}

@hexploitable
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants