Use a forked EntityManager for each transaction #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbt
force-pushed
the
master
branch
2 times, most recently
from
3d332ff
to
268f5a9
Compare
Currently, a global EntityManager is used for every operation. This causes an error that can be resolved by setting `allowGlobalContext: true`. But that isn't a great fix, because if you ever make an edit to an entity that fails, you'll never be able to make another change because the global context caches the failed change and never releases it.
dziraf
approved these changes
Jun 23, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
## [1.1.2](v1.1.1...v1.1.2) (2022-06-23) ### Bug Fixes * use a forked EntityManager for each transaction ([#12](https://github.com/SoftwareBrothers/adminjs-mikroorm/issues/12))([@corbt](https://github.com/corbt)) ([076e740](076e740))
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a global EntityManager is used for every operation. This causes an error that can be resolved by setting
allowGlobalContext: true. But that isn't a great fix, because if you ever make an edit to an entity that fails, you'll never be able to make another change because the global context caches the failed change and never releases it.