Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootPath as slash causes endless redirect loop #24

Closed
SimonB407 opened this issue Aug 17, 2020 · 1 comment
Closed

rootPath as slash causes endless redirect loop #24

SimonB407 opened this issue Aug 17, 2020 · 1 comment
Labels

Comments

@SimonB407
Copy link
Contributor

Lukáš Novotný wrote on slack:

Adminbro end in endless redirect loop when I set rootPath: "/"? It does a redirect to /login but it end in redirect loop.

Code to reproduce

const server = express()
const adminBro = new AdminBro({
    rootPath: "/",
    loginPath: "/login",
    logoutPath: "/logout",
    ...
})
const adminRouter = buildAdminRouter(adminBro)
server.use("/", adminRouter)
server.listen(3000, () => {
    console.log(`Server running at 3000`)
})
github-actions bot pushed a commit that referenced this issue Sep 28, 2020
## [3.0.1](v3.0.0...v3.0.1) (2020-09-28)

### Bug Fixes

* error with redirect where root path is /fixes [#24](#24) ([cc3d5fc](cc3d5fc))
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

johnolson2219 pushed a commit to johnolson2219/admin_express that referenced this issue Aug 26, 2023
## [3.0.1](SoftwareBrothers/adminjs-expressjs@v3.0.0...v3.0.1) (2020-09-28)

### Bug Fixes

* error with redirect where root path is /fixes [#24](SoftwareBrothers/adminjs-expressjs#24) ([cc3d5fc](SoftwareBrothers/adminjs-expressjs@cc3d5fc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant