Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix source blur in search #958

Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix(frontend): fix source blur in search #958

merged 1 commit into from
Jun 24, 2019

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Jun 20, 2019

handleRouteChange reset source in state to undefined
so we need to reset it to an empty string so we can compare new value
to the one in state and bail update if there no change

fix #937

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #958 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
+ Coverage   83.55%   83.59%   +0.03%     
==========================================
  Files         191      192       +1     
  Lines        1989     2011      +22     
  Branches      299      303       +4     
==========================================
+ Hits         1662     1681      +19     
- Misses        285      287       +2     
- Partials       42       43       +1
Impacted Files Coverage Δ
...ages/code-du-travail-frontend/src/search/Search.js 55.38% <66.66%> (+1.41%) ⬆️
...ode-du-travail-data/dataset/tag_extractor/index.js 85% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d165e4...510c787. Read the comment docs.

handleRouteChange reset source in state to undefined
so we need to reset it to an empty string so we can compare new value
to the one in state and bail update if there no change
@lionelB lionelB merged commit 7a1d139 into master Jun 24, 2019
@lionelB lionelB deleted the lionelb-fix-937 branch June 24, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[search]: navigation clavier
3 participants