Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lionelb/faceting suite #497

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Lionelb/faceting suite #497

merged 3 commits into from
Feb 7, 2019

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Feb 1, 2019

  • ajout d'un lien pour relancer la recherche sur l'ensemble des source, lorsque qu'aucun résultats de recherche ne remonte pour une source donnée

  • remontée de la source (anciennement appelée facet) dans les données envoyé par formulaire

fixes #299

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #497 into master will increase coverage by 0.2%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #497     +/-   ##
=========================================
+ Coverage   72.66%   72.87%   +0.2%     
=========================================
  Files          90       91      +1     
  Lines        1061     1080     +19     
  Branches      161      163      +2     
=========================================
+ Hits          771      787     +16     
- Misses        261      264      +3     
  Partials       29       29
Flag Coverage Δ
#true 72.64% <62.5%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...ages/code-du-travail-frontend/src/common/Answer.js 55.55% <ø> (+5.55%) ⬆️
...de-du-travail-frontend/src/search/SearchResults.js 76% <100%> (-0.93%) ⬇️
...code-du-travail-frontend/src/search/SearchQuery.js 62.5% <100%> (ø) ⬆️
...ode-du-travail-frontend/src/common/FeedbackForm.js 100% <100%> (ø) ⬆️
...de-du-travail-frontend/src/common/FeedbackModal.js 100% <100%> (ø) ⬆️
...ages/code-du-travail-frontend/src/search/Search.js 43.13% <45.45%> (-0.87%) ⬇️
...ode-du-travail-data/dataset/tag_extractor/index.js 85% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c262ad9...2f5aa73. Read the comment docs.

Copy link
Contributor

@douglasduteil douglasduteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionelB lionelB force-pushed the lionelb/faceting-suite branch from 1272ab1 to 2f5aa73 Compare February 7, 2019 13:58
@lionelB lionelB merged commit 6212ae9 into master Feb 7, 2019
@lionelB lionelB deleted the lionelb/faceting-suite branch February 7, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facetting suites
2 participants