Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix theme navigation #376

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Dec 14, 2018

fix la navigation dans les themes suite a un refacto des propTypes malencontreux :(

fixes #372

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #376   +/-   ##
======================================
  Coverage    46.6%   46.6%           
======================================
  Files          63      63           
  Lines         796     796           
  Branches      113     113           
======================================
  Hits          371     371           
  Misses        384     384           
  Partials       41      41
Impacted Files Coverage Δ
...ackages/code-du-travail-frontend/src/Categories.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update badcfee...9ec2375. Read the comment docs.

@revolunet
Copy link
Member

je ne me souviens plus pourquoi certains slugs sont array, d'autres en string mais on ferait bien de normaliser, là ce devrait pas marcher quand params.slug est un array ?

@lionelB
Copy link
Contributor Author

lionelB commented Dec 14, 2018

en fait c'est le link qui le transform l'array en url propre, si on lui passe une chaine avec "/" il l'encode :)

@lionelB lionelB merged commit 2bf4582 into master Dec 14, 2018
@lionelB lionelB deleted the lionelb/fix-theme-navigation branch December 14, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

les sous theme affiche un page vide
2 participants