Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simulator): init folder for publicode models #3416

Merged
merged 6 commits into from
Apr 6, 2021

Conversation

m-maillot
Copy link
Contributor

I created a specific package for the publicodes models.
The idea is to separate models from the UI code. Later, we can move it in a specific repo and populate the frontend from the admin (like fiche SP, kalidata...), for instance.

I create a project with typescript. The idea is to move our javascript to typescript code (like admin).

This package will contain models but also unit tests to validate models. We can add rules to our models quickly with no fear (or a little bit).

I don't have:

  • implement the solution to link this package to the frontend (the idea is to use the frontend API to provide the models)
  • implement linter, CI,... I think it will be more efficient if a more advanced developer can help me (pair programming session ? :) )
  • implement the whole model for computing retirement notice.

@m-maillot m-maillot requested review from lionelB and revolunet April 1, 2021 13:38
@m-maillot m-maillot force-pushed the feature/publicode-modele branch from 18bdb10 to 4d241df Compare April 6, 2021 12:00
@m-maillot m-maillot merged commit 71f7503 into SocialGouv:master Apr 6, 2021
@m-maillot m-maillot deleted the feature/publicode-modele branch April 6, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants