Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): pretty print documents #3172

Merged
merged 2 commits into from
Nov 26, 2020
Merged

fix(frontend): pretty print documents #3172

merged 2 commits into from
Nov 26, 2020

Conversation

UnbearableBear
Copy link
Contributor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -53,6 +53,9 @@ const { breakpoints, fonts, spacings } = theme;

const Nav = styled.nav`
margin-bottom: ${spacings.small};
@media print {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it could be useful to have the breadcrumbs printed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think breadcrumbs has a navigation purpose mostly. There already is the main theme displayed, in the printed document, just above the title

@@ -126,4 +126,7 @@ const ShareContainer = styled(Container)`
@media (max-width: ${breakpoints.mobile}) {
justify-content: flex-start;
}
@media print {
Copy link
Contributor

@lionelB lionelB Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to remove it since it's also hide in the <Share Component /> ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the two used, one has a text inside so I'd say yes. Plus it's safer for the print layout too

@UnbearableBear UnbearableBear merged commit 5854776 into master Nov 26, 2020
@UnbearableBear UnbearableBear deleted the manu/print branch November 26, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants