-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): pretty print documents #3172
Conversation
@@ -53,6 +53,9 @@ const { breakpoints, fonts, spacings } = theme; | |||
|
|||
const Nav = styled.nav` | |||
margin-bottom: ${spacings.small}; | |||
@media print { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it could be useful to have the breadcrumbs printed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think breadcrumbs has a navigation purpose mostly. There already is the main theme displayed, in the printed document, just above the title
@@ -126,4 +126,7 @@ const ShareContainer = styled(Container)` | |||
@media (max-width: ${breakpoints.mobile}) { | |||
justify-content: flex-start; | |||
} | |||
@media print { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to remove it since it's also hide in the <Share Component />
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the two used, one has a text inside so I'd say yes. Plus it's safer for the print layout too
✨