Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add date on fiche minisitere #304

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Nov 21, 2018

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #304 into master will decrease coverage by 1.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   15.23%   13.78%   -1.46%     
==========================================
  Files          51       53       +2     
  Lines         768      849      +81     
  Branches      105      118      +13     
==========================================
  Hits          117      117              
- Misses        588      656      +68     
- Partials       63       76      +13
Impacted Files Coverage Δ
...rc/outils/indemniteLicenciement/ccn/Result_0044.js 0% <0%> (ø) ⬆️
packages/code-du-travail-frontend/src/piwik.js 0% <0%> (ø) ⬆️
...l-frontend/src/common/ServiceRenseignementModal.js 0% <0%> (ø) ⬆️
...ages/code-du-travail-frontend/src/lib/FuseInput.js 0% <0%> (ø) ⬆️
...-du-travail-frontend/src/common/ConventionModal.js 0% <0%> (ø) ⬆️
...du-travail-frontend/src/common/ConventionPicker.js 0% <0%> (ø) ⬆️
...kages/code-du-travail-frontend/src/common/Alert.js 0% <0%> (ø)
...ode-du-travail-frontend/src/common/FeedbackForm.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2421697...388bd45. Read the comment docs.

const [day, month, year] = date.textContent.trim().split(".");
const dateRaw = $(article, ".date--maj") || $(article, ".date--publication");
const [date] = dateRaw.textContent.match(/([0-9\.]+)$/);
const [day, month, year] = date.split(".");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incroyable ce format de date 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on ne se moque pas ;)

@lionelB lionelB merged commit 0cb0338 into master Nov 21, 2018
@lionelB lionelB deleted the lionelb/add-date-to-fiche-ministere branch November 21, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants