feat(ui): add burger nav to UI #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pti prob de CI |
Elle était funky celle là mais j'ai trouvé le soucis ! |
|
Je vais essayer de virer le package que j'utilise pour le burger menu et en recoder un. C'est pas possible tout le code que ça importe pour faire un truc aussi bateau. Et rollup il l'aime pas mais alors pas du tout ce truc |
UnbearableBear
changed the title
UnbearableBear
changed the title
UnbearableBear
force-pushed
the
manu/ui-burger
branch
from
5b0b89c to
4de6441
Compare
UnbearableBear
force-pushed
the
manu/ui-burger
branch
from
4de6441 to
09036be
Compare
UnbearableBear
changed the title
nkrmr
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GROS CLEAN
J'ai viré un package que j'avais utilisé un peu à contrecoeur. J'ai repris les modals qu'on utilisait déjà. Résultats: Plus d'accessibilité, moins de styles, moins de js, moins de bugs !
Et désormais le burger est accessible dans l'UI directement
e0bc1e1
(⬆️ tout est là, à part la config next js de revert dans le dernier commit)