feat(frontend): implementing UI #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
reviewed
Jan 10, 2020
| <StyledTitle | ||
| shift={spacings.xmedium} | ||
| variant="primary" | ||
| marginTop={Boolean(answers.generic)} |
There was a problem hiding this comment.
Ton nom sera le mien !
There was a problem hiding this comment.
as you prefer !
lionelB
reviewed
Jan 10, 2020
| rounded={variant !== "primary"} | ||
| variant={variant} | ||
| position="left" | ||
| length="100%" |
There was a problem hiding this comment.
Sort of, but it can be either width or height depending on the stripe's position
There was a problem hiding this comment.
Didn't catch that :/
Is it validate using propTypes ? I guess position is an enum
Does it work if I put length="3rem"
There was a problem hiding this comment.
UnbearableBear
force-pushed
the
manu/encart-perso
branch
from
deb8551 to
05b5492
Compare
lionelB
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I'm late !