fix(api): preserve order when merging semantic and fulltext results #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
force-pushed
the
lionelb/fix-merge-sem-fulltext-results
branch
from
7ad8413 to
4b696c6
Compare
revolunet
approved these changes
Dec 31, 2019
lionelB
force-pushed
the
lionelb/fix-merge-sem-fulltext-results
branch
from
4b696c6 to
1b55827
Compare
|
wait before merging, need more testing |
lionelB
force-pushed
the
lionelb/fix-merge-sem-fulltext-results
branch
from
1b55827 to
48e6ccb
Compare
revolunet
approved these changes
Jan 6, 2020
| {} | ||
| ) | ||
| ); | ||
| const removeDuplicate = (arr, predicate = predicateFn) => |
There was a problem hiding this comment.
On a vraiment besoin d'un flatMap ?
Juste un filter avec un some dedans ça me parait un peu plus explicite pour filtrer si on n'a pas de soucis de sous tableaux !
arr.filter(
(item, index) =>
!arr.some(
(subItem, subIndex) =>
subIndex < index && predicate(item) === predicate(subItem)
)
);
There was a problem hiding this comment.
filter is ok but I found the some syntax very hard to read
There was a problem hiding this comment.
It's basically the same than .find imho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR
fix #2095, #2152