feat(ui): add new section #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
reviewed
Dec 23, 2019
| }; | ||
|
|
||
| const StyledSection = styled.div` | ||
| margin: ${({ decorated }) => (decorated ? spacings.medium : 0)} 0; |
There was a problem hiding this comment.
we should probably add a min-height when StyledSection is decorated to avoid weird border-radius effect ?
UnbearableBear
force-pushed
the
manu/ui-refinement
branch
from
750f4b4 to
fe151a9
Compare
lionelB
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout d'une prop "decorated" à une section qui la "décore"
@lionelB J'ai aussi update les snaps ici