proto elastic suggester

[lionelB]

wip

[rmelisson]

Fix #1540 #1542 #841

[rmelisson]

whoops, my bad c'est toujours WIP, je crois pas que je puisse revert de open à draft

[lionelB]

can you use async in test case ? It would be easier to read.

test("return suggestions for re in the right format", async () => {
 const response = await request(app.callback()).get(`/api/v1/suggest?q=re`);
 expect(response.status).toBe(200)
 expect(response.get("Content-type").toMatch(/json/);
 expect(response.body).toMatchSnapshot()
})

if can also create a getSuggestion helder

async function getSuggestion(query) {
   return request(app.callback()).get(`/api/v1/suggest?q=${query}`);
}

[rmelisson]

getSuggestions still return a promise, but the test cases are now using async for readability. Hope you're fine with this.

[lionelB]

@rmelisson Looks good. just few comments :) nice job!

[revolunet]