Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contributions): sauvegarde de la date de mise à jour des contribs #1448

Merged
merged 14 commits into from
Jul 16, 2024

Conversation

carolineBda
Copy link
Contributor

@carolineBda carolineBda commented Jul 11, 2024

@carolineBda carolineBda marked this pull request as draft July 11, 2024 12:55
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@carolineBda carolineBda marked this pull request as ready for review July 11, 2024 13:38
@carolineBda carolineBda requested review from Viczei, maxgfr and m-maillot and removed request for Viczei and maxgfr July 11, 2024 13:38
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top !!!!

Comment on lines -84 to 88
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url>
<loc>${baseUrl}/</loc>
<lastmod>${new Date(latestPost).toISOString()}</lastmod>
<priority>0.8</priority>
</url>
${pages.concat(staticPages, glossaryPages).join("")}
</urlset>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url><loc>${baseUrl}/</loc><lastmod>${new Date(latestPost).toISOString()}</lastmod><priority>0.8</priority></url>
${pages.concat(staticPages, glossaryPages).join("")}
</urlset>
`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est juste du formatage du coup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui c'ets la seule url du fichier xml qui était mal formattée :)

Copy link

@@ -61,7 +61,7 @@ export const Comment = ({ comment, onDelete }: Props) => {
<Delete fontSize="inherit" />
</IconButton>
</Box>
<Box sx={{ marginTop: 1, whiteSpace: "pre-line" }}>{comment.content}</Box>
<Typography sx={{ fontSize: "small" }}>{comment.content}</Typography>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petit reformattage 😇

@@ -229,27 +231,47 @@ function FilesPage() {
minWidth: 0,
}}
>
<Box
<Typography
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai juste fixé le pb des bouton qui disparaissent sur la droite

Copy link

🎉 Deployment for commit 37d9a38 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-37d9a388bbcd9741ae46e3c8c795e117578f30ac
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-37d9a388bbcd9741ae46e3c8c795e117578f30ac
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-37d9a388bbcd9741ae46e3c8c795e117578f30ac
Debug

@maxgfr maxgfr merged commit 0195d8e into master Jul 16, 2024
30 checks passed
@maxgfr maxgfr deleted the linked-date-contribs branch July 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Afficher la date de mise à jour sur les contribs
3 participants