From 6b46d80ff7124e9e931016a824702b8c7713f866 Mon Sep 17 00:00:00 2001
From: Lionel <lionel@lumographe.fr>
Date: Fri, 14 Aug 2020 11:37:50 +0200
Subject: [PATCH] fix(alerts): batch alert insert (#78)

---
 targets/alert-cli/src/batchPromises.js | 21 +++++++++++++++++++++
 targets/alert-cli/src/index.js         | 26 ++++++++++++++++++++------
 2 files changed, 41 insertions(+), 6 deletions(-)
 create mode 100644 targets/alert-cli/src/batchPromises.js

diff --git a/targets/alert-cli/src/batchPromises.js b/targets/alert-cli/src/batchPromises.js
new file mode 100644
index 000000000..30d26c41a
--- /dev/null
+++ b/targets/alert-cli/src/batchPromises.js
@@ -0,0 +1,21 @@
+/**
+ * @template A
+ * @template B
+ * @param {A[]} items
+ * @param {(a:A) => Promise<B>} handler
+ * @param {number} batchSize
+ */
+export async function batchPromises(items, handler, batchSize) {
+  const array = items.slice();
+  /** @type {({status: "rejected", reason:Object} | {status:"fullfilled", value:B})[]} */
+  let results = [];
+  let i = 0;
+  while (array.length) {
+    const res = await Promise.allSettled(
+      array.splice(0, batchSize).map(handler)
+    );
+    console.log(`Performed operation for batch ${++i}.`);
+    results = results.concat(res);
+  }
+  return results;
+}
diff --git a/targets/alert-cli/src/index.js b/targets/alert-cli/src/index.js
index 61ac2dbe6..554d0f783 100644
--- a/targets/alert-cli/src/index.js
+++ b/targets/alert-cli/src/index.js
@@ -4,6 +4,7 @@ import nodegit from "nodegit";
 import path from "path";
 import semver from "semver";
 
+import { batchPromises } from "./batchPromises";
 import { ccns } from "./ccn-list.js";
 import { compareArticles } from "./compareTree.js";
 import { getRelevantDocuments } from "./relevantContent.js";
@@ -388,7 +389,6 @@ async function getDiffFromTags(tags, repositoryId) {
   const diffProcessor = getDiffProcessor(repositoryId);
 
   for (const tag of newTags) {
-    console.error(repositoryId, tag.ref);
     const previousCommit = previousTag.commit;
     const { commit } = tag;
     const [prevTree, currTree] = await Promise.all([
@@ -442,16 +442,30 @@ async function main() {
       if (result.changes.length === 0) {
         console.log(`no update for ${result.repository}`);
       } else {
-        const inserts = await Promise.all(
-          result.changes.map((diff) => insertAlert(result.repository, diff))
+        const inserts = await batchPromises(
+          result.changes,
+          (diff) => insertAlert(result.repository, diff),
+          5
         );
-        inserts.forEach((insert) => {
-          const { ref, repository, info } = insert;
+
+        const fullfilledInserts = /**@type {{status:"fullfilled", value:alerts.Alert}[]} */ (inserts.filter(
+          ({ status }) => status === "fullfilled"
+        ));
+        const rejectedInsert = inserts.filter(
+          ({ status }) => status === "rejected"
+        );
+        fullfilledInserts.forEach((insert) => {
+          const { ref, repository, info } = insert.value;
           console.log(
             `insert alert for ${ref} on ${repository} (${info.file})`
           );
         });
-        console.log(`create ${inserts.length} alert for ${result.repository}`);
+        console.log(
+          `create ${fullfilledInserts.length} alerts for ${result.repository}`
+        );
+        console.error(
+          `${rejectedInsert.length} alerts failed to insert in ${result.repository}`
+        );
       }
 
       const update = await updateSource(result.repository, result.newRef);