Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datamap not saving properly #42

Open
PLatCIC opened this issue Jan 7, 2025 · 3 comments
Open

Datamap not saving properly #42

PLatCIC opened this issue Jan 7, 2025 · 3 comments

Comments

@PLatCIC
Copy link

PLatCIC commented Jan 7, 2025

When editing a datamap to get rid of datamap errors, it appears that changes are immediately saved since when a change is made to the map any associated errors immediately disappear. However, the changes are not yet saved to disk since they do not appear to GitHub until either a Save on the project is done or the project is closed. This ends up leaving changes lying around unexpectedly. Ideally when the datamap is changed it should be saved immediately automatically. If that's too hard, it would help to at least show something that says it is not saved, like the "Modified" tag on a code file.

@garfieldnate
Copy link
Contributor

I don't think we have any undo functionality for datamap changes, so it would be safer to implement your second suggestion. How about a little icon or message in the status bar at the bottom of the window?

@PLatCIC
Copy link
Author

PLatCIC commented Jan 7, 2025

That would help some, but not really solve the whole problem. If I decide I want to discard changes I made to the datamap and I see that the status is not saved, I might think I can discard the changes by simply closing the project, but in fact as things work now that will save the changes. So the only way to discard changes is to delete them one by one.

@garfieldnate
Copy link
Contributor

For that, I will add the bug label :D You should always be prompted to save on exit, rather than saving just being automatic. That is a data loss issue as far as I'm concerned. I would think that my recent changes would have fixed that, so I will have to investigate. It may be fixed already in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants