Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have cibuildwheel use TestPythonSML.py for test command #460

Closed
2 tasks done
ShadowJonathan opened this issue May 15, 2024 · 0 comments · Fixed by #461
Closed
2 tasks done

Have cibuildwheel use TestPythonSML.py for test command #460

ShadowJonathan opened this issue May 15, 2024 · 0 comments · Fixed by #461

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented May 15, 2024

After #448

Currently this following python code is executed to test:

import soar_sml

k = soar_sml.Kernel.CreateKernelInNewThread()
a = k.CreateAgent('soar')

assert(a.ExecuteCommandLine('echo hello world').strip() == 'hello world')

This makes sure the library at least imports, and the kernel can start, but it doesn't do a deeper test of the library itself.

We could (re)use TestPythonSML.py for this, and run it for every single wheel. This'll increase build times, but it could be a more thorough check of what we send to pypi.


Currently there are two lines / chunks which need to be properly converted before we can change the test command to python TestPythonSML.py;

  • This import line needs to fallback to using soar_sml, if this is installed that way.

  • This path-determining line needs to be replaced if soar_sml is imported, since then the file is installed in an installation directory.
    Instead, we should probably either look at an environment variable, or simply assume the current directory, or possibly walk up directory parents until we see SoarUnitTests

@ShadowJonathan ShadowJonathan changed the title Have cibuildwheel use TestPythonSML for test command Have cibuildwheel use TestPythonSML.py for test command May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant