Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Dynamic Table Support for Stream Resource #2413

Open
dcwangmit01 opened this issue Jan 24, 2024 · 7 comments
Open

feat: Add Dynamic Table Support for Stream Resource #2413

dcwangmit01 opened this issue Jan 24, 2024 · 7 comments
Assignees
Labels
category:resource feature-request Used to mark issues with provider's missing functionalities resource:dynamic_table Issue connected to the snowflake_dynamic_table resource resource:stream Issue connected to the snowflake_stream resource

Comments

@dcwangmit01
Copy link

Terraform CLI and Provider Versions

$ terraform version
Terraform v1.7.1
on darwin_arm64
+ provider registry.terraform.io/snowflake-labs/snowflake v0.84.1

Use Cases or Problem Statement

Currently the Streams resource may be created on_table, on_view, and on_stage. However, there is no support for on_dynamic_table.

Effectively, the request is to enable the following in Terraform.

CREATE OR REPLACE STREAM deltaStream ON DYNAMIC TABLE dynamicTable

Relevant Issue:
#1922

Proposal

Enable this capability for creating streams on Dynamic Tables in the same way that on_table, on_view, and on_stage are supported.

How much impact is this issue causing?

Medium

Additional Information

No response

@dcwangmit01 dcwangmit01 added the feature-request Used to mark issues with provider's missing functionalities label Jan 24, 2024
@dcwangmit01 dcwangmit01 changed the title Add Dynamic Table Support for Stream Resource feat: Add Dynamic Table Support for Stream Resource Jan 24, 2024
@sfc-gh-asawicki
Copy link
Collaborator

Hey @dcwangmit01. Thanks for creating the issue.

We have existing resources' rework on our roadmap: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#our-roadmap. I will bump this resource's priority slightly.

@ghost
Copy link

ghost commented Feb 23, 2024

Hey @dcwangmit01. Thanks for creating the issue.

We have existing resources' rework on our roadmap: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#our-roadmap. I will bump this resource's priority slightly.

Hi. Is this something that I could help push forward by contributing code? My team needs this functionality in order to justify our use of the provider. Not having it means two tools instead of one for us. Thanks!

@sfc-gh-asawicki
Copy link
Collaborator

Hey @josdotso. We are open to contributions!

However, we do not have yet clear contribution guidelines and PR requirements written down inside the repository. They are still to come in the upcoming weeks. If this is not a problem for you, we will be happy to review the change.

@sfc-gh-jcieslak sfc-gh-jcieslak added resource:dynamic_table Issue connected to the snowflake_dynamic_table resource resource:stream Issue connected to the snowflake_stream resource category:resource labels May 20, 2024
@AZenat
Copy link

AZenat commented Jun 10, 2024

Hey,

What is the update on that feature ?
I'm willing to take it if you're busy @josdotso.

@sfc-gh-asawicki
Copy link
Collaborator

Hey @AZenat. No update from our side yet. However, we have described the contribution guidelines: https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/CONTRIBUTING.md#contributing, so it should be easier to make a contribution. :)

@AZenat
Copy link

AZenat commented Jun 10, 2024

Thanks @sfc-gh-asawicki, I will try to do it then.

@sfc-gh-jmichalak
Copy link
Collaborator

Hi @AZenat 👋
Any update on your side? We will rework streams soon, and will probably split this resource into different ones for each object type on which the streams are created.

@sfc-gh-jmichalak sfc-gh-jmichalak self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:resource feature-request Used to mark issues with provider's missing functionalities resource:dynamic_table Issue connected to the snowflake_dynamic_table resource resource:stream Issue connected to the snowflake_stream resource
Projects
None yet
Development

No branches or pull requests

5 participants