From e600a3a978e6fc1cc55ff115f01a166c2fd24273 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Cie=C5=9Blak?= Date: Wed, 28 Aug 2024 12:48:49 +0200 Subject: [PATCH] changes after review --- docs/resources/database_role.md | 4 ++-- pkg/resources/database_role.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/resources/database_role.md b/docs/resources/database_role.md index 3d0ae97978..613024f51e 100644 --- a/docs/resources/database_role.md +++ b/docs/resources/database_role.md @@ -32,8 +32,8 @@ resource "snowflake_database_role" "test_database_role" { ### Required -- `database` (String) The database in which to create the database role. -- `name` (String) Specifies the identifier for the database role. +- `database` (String) The database in which to create the database role. Due to technical limitations (read more [here](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/docs/technical-documentation/identifiers_rework_design_decisions.md#known-limitations-and-identifier-recommendations)), avoid using the following characters: `|`, `.`, `(`, `)`, `"` +- `name` (String) Specifies the identifier for the database role. Due to technical limitations (read more [here](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/docs/technical-documentation/identifiers_rework_design_decisions.md#known-limitations-and-identifier-recommendations)), avoid using the following characters: `|`, `.`, `(`, `)`, `"` ### Optional diff --git a/pkg/resources/database_role.go b/pkg/resources/database_role.go index c9dcea7488..ee98900a7b 100644 --- a/pkg/resources/database_role.go +++ b/pkg/resources/database_role.go @@ -21,14 +21,14 @@ var databaseRoleSchema = map[string]*schema.Schema{ "name": { Type: schema.TypeString, Required: true, - Description: "Specifies the identifier for the database role.", + Description: blocklistedCharactersFieldDescription("Specifies the identifier for the database role."), DiffSuppressFunc: suppressIdentifierQuoting, }, "database": { Type: schema.TypeString, Required: true, ForceNew: true, - Description: "The database in which to create the database role.", + Description: blocklistedCharactersFieldDescription("The database in which to create the database role."), DiffSuppressFunc: suppressIdentifierQuoting, }, "comment": {