Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Prefix connection data not doing anything #18

Closed
2 tasks done
FluffyDiscord opened this issue Mar 14, 2024 · 6 comments
Closed
2 tasks done

[BUG] Prefix connection data not doing anything #18

FluffyDiscord opened this issue Mar 14, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@FluffyDiscord
Copy link

System information

Describe your setup, so we can understand the cause of the bug better

  • Android version: Android 12
  • Android vendor: OneUI 4.1
  • Mode: Shizuku
  • WADBS version: 1.1
  • Where did you get the app from: GitHub Releases page
  • Any additional information you would like to share about your system

Problem description

Tapping on Connection data widget that I added on my home screen copies to clipboard only the address and port. The "Prefix connection data" does not work as it's not being appended.

  • This issue was not reported before
  • I agree to keep the discussion polite and on point
@FluffyDiscord FluffyDiscord added the bug Something isn't working label Mar 14, 2024
@Smooth-E
Copy link
Owner

Hello! This is the intended behavior. The data is only prefixed when you turn on wireless debugging. Though it is only clarified in the Russian translation of this option's extended description. I think, I can add another switch for whether to also prefix data when just copying (using the informative widget) or only prefix it when using the switch widget. What are your thoughts on this, do you (and potentially other users) need it?

My thinking behind it was that you only need instant connection when you first enable wireless debugging, thus needing to prefix. The informative widget allows you to copy connection data "just in case". If you want to pair, just tap the switch widget twice 🤷

@FluffyDiscord
Copy link
Author

FluffyDiscord commented Mar 14, 2024

Oh, yeah there might be a bit of confusion then. The adb debugging definitely did not connect to my PC when I turned the wireless debug on using the toggle widget. I did not check though if, as you say, turning on wireless adb debug using the widget also copies the connection settings to clipboard with the prefix to then just manually the clipboard content to PC using KDE connect. I will have to check it tomorrow and will report back - afair I did not see instant connection button, or it didn't worked.

This may be instead of a bug, a feature request then.

@Smooth-E
Copy link
Owner

Smooth-E commented Mar 14, 2024

Instant connection is achieved with turning on "Prefix connection data" and "KDE Connect integration". Then tap the switch widget and it should work. Though, read scripts first.

@FluffyDiscord
Copy link
Author

Yes I did that and had the python script running.

@Smooth-E
Copy link
Owner

Smooth-E commented Mar 14, 2024

Just checked your first message. Unfortunately, KDE Connect integration requires root access for now. Switch's description is modified to include this information with this commit (will be out in the next release). You can also check out #15

@FluffyDiscord
Copy link
Author

Yes haha, it makes sense now. I am closing this issue, since it's kind of duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants