Fixes to hardware config editing/display #2765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If name not specified when loading config then 'save' raises exception
For example,
Basic_Ota
sample doesn't have itsname
field set inota.hw
:make hwconfig-edit
So ensure we provide a default name based on filename.
Ensure all sample .hw files have names
For consistency.
Remove 'unused_before' and 'unused_after' fields from
make hwconfig
outputThese are only used for map building so shouldn't be visible.
Example:
Don't set name, comment fields from option data
For example,
Basic_Blink
sample uses default config. Runningmake hwconfig
gives:If we run
make hwconfig HWCONFIG_OPTS=4m
we get this:The
name
andcomment
have been wiped out, should be as before.Fix use of
not in
andis not
operatorse.g.
x not in [...]
preferred tonot x in [...]