Fix potential memory leak in TcpClient::send
#2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
changed the title
TcpClient::sendTcpClient::send
mikee47
force-pushed
the
fix/TcpClient-send-leak
branch
from
3609357
to
e34f514
Compare
mikee47
force-pushed
the
fix/TcpClient-send-leak
branch
from
e34f514
to
e7b7c14
Compare
mikee47
changed the title
TcpClient::sendTcpClient::send
slaff
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a concern raised by Coverity. The
TcpClient::send(const char*, ...method is tricky because it can either use the existing stream or create a new one. Further leaks are possible inTcpClient::send(IDataSourceStream*, ...when inspecting the failure paths. The code has been refactored usingstd::unique_ptrguards.