Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esp8266 timer1 testing #2709

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Commits on Jan 12, 2024

  1. HostTests hangs in Clocks module when comparing Timer1 with system …

    …time.
    
    The is because a callback interrupt routine hasn't been set on the timer.
    This doesn't affect normal code which accesses the timer via HardwareTimer which contains
    logic to ensure this doesn't happen.
    mikee47 committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    808fd4d View commit details
    Browse the repository at this point in the history
  2. Timer1 now failing check with /16 divisor

    This is because it's only a 23-bit timer which limits maximum to about 1.7 seconds (test duration is 2 seconds).
    Fixed by restricting duration to timer maximum.
    mikee47 committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d19fb93 View commit details
    Browse the repository at this point in the history
  3. Improve elapsed tick calculation

    Check whether timer is an UP or DOWN counter
    Use timer maximum tick value to ensure counter wraps correctly
    mikee47 committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    9360204 View commit details
    Browse the repository at this point in the history
  4. Reduce Host test loops from 2000 to 50

    Runs more slowly on Host
    mikee47 committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    dacb6fb View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Tidy code

    mikee47 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    adebc0e View commit details
    Browse the repository at this point in the history