Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esp8266 'no network' build of HostTests #2702

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jan 9, 2024

Implementations of system_get_sdk_version() and system_get_chip_id() required.

Copy link

what-the-diff bot commented Jan 9, 2024

PR Summary

  • Enhancements to component.mk

    • Updated the build sequence rule to include SDK version. This change ensures our software keeps in step with the Software Development Kit updates.
    • Extended the linker flags to reference the SDK version. This approach binds our project closer to the SDK, ensuring we optimise for the features and quirks of the current version.
  • Update to user_interface.c

    • Incorporated an additional library to leverage functionalities related to key hardware peripherals.
    • Introduced new functions to retrieve SDK version and compute chip ID. These functions add to our ability to collect system-level details, crucial for identifying system status and resolving potential issues.
    • system_get_sdk_version() helps to know the version of the SDK we are currently using.
    • system_get_chip_id() pinpoints to the specific chip at use based on the MAC address. Understanding which chip is in use can be invaluable, especially in understanding related performance issues or limitations.

@mikee47
Copy link
Contributor Author

mikee47 commented Jan 9, 2024

Re. CI failure I'll rebase after #2703

@slaff
Copy link
Contributor

slaff commented Jan 10, 2024

I'll rebase after #2703

Go for it.

Implementations of `system_get_sdk_version()` and `system_get_chip_id()` required.
@mikee47 mikee47 force-pushed the fix/esp8266-hostests-no-wifi branch from 5f48a12 to de797f3 Compare January 10, 2024 09:04
@slaff slaff merged commit 2233b3d into SmingHub:develop Jan 10, 2024
45 of 46 checks passed
@mikee47 mikee47 deleted the fix/esp8266-hostests-no-wifi branch January 12, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants