Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESP32 IDF version 5.2 (beta) #2694

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jan 3, 2024

TODO:

  • No quick fix for Windows build issues, so probably just avoid compiling the problem code.
  • GDB doesn't work for esp32 with IDF 5.2. Toolset directory layout has changed.

Copy link

what-the-diff bot commented Jan 3, 2024

PR Summary

  • Extended Support for New IDF Version
    The team worked on extending our software support for another Infrastructure Driver Framework (IDF) version, 5.2. This action can be observed in various files changed to include additional options or checks based on this version.

  • Modified Workflow File
    The workflow file .github/workflows/ci-esp32.yml was updated to allow jobs to run with the new 5.2 IDF version.

  • Changes in Various Source Files
    Several source files like uart.cpp, clk.c, Digital.cpp, and SPI.cpp were modified, mainly to accommodate and ensure smooth operation with the latest IDF version 5.2.

  • Updated Compilation Flags
    The file component.mk now has updated compilation flags for the new IDF versions 5.0 and 5.2.

  • Updated Developer Documentation
    The documentation README.rst in the Sming/Arch/Esp32/ directory has been updated to reflect that our application now also supports IDF version 5.2.

  • Toolset Prefix Determination
    Both idf_tools.py and build.mk files were updated to determine the ESP32 toolset prefix based on the IDF version, thus enhancing the flexibility of our tooling platform.

  • Upgraded Installation Script
    The script install.cmd has been improved to support installing the Python environment for IDF version 5.2, thereby aiding the setup process for developers using this version.

  • Environment Variable Removal
    The team eliminated the ESP32_PYTHON_PATH environment variable from setenv.ps1 and export.sh scripts for a cleaner and efficient environment setup.

@mikee47
Copy link
Contributor Author

mikee47 commented Jan 4, 2024

CI failures for Windows (IDF 5.2) are a recurrence of the issues addressed in #2086, #2118. Early builds were failing for other SDK versions too, this was fixed by restricting number of include directories.

Builds fail for esp32, esp32c3 and esp32s3 variants, but esp32s2 and esp32c2 both complete without error. It's not down to the architecture then, as one is xtensa the other riscv.

@slaff slaff added this to the 5.2.0 milestone Jan 4, 2024
@slaff slaff changed the title Add support for ESP32 IDF version 5.2 (beta) [WIP] Add support for ESP32 IDF version 5.2 (beta) Jan 8, 2024
@mikee47 mikee47 changed the title [WIP] Add support for ESP32 IDF version 5.2 (beta) Add support for ESP32 IDF version 5.2 (beta) Jan 8, 2024
@slaff slaff merged commit 8edfec9 into SmingHub:develop Jan 9, 2024
46 checks passed
@mikee47 mikee47 deleted the feature/idf-5.2 branch January 9, 2024 09:01
@slaff slaff mentioned this pull request Feb 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants