Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axl_ssl_read hangs on memory allocation failure #1615

Closed
mikee47 opened this issue Feb 10, 2019 · 2 comments
Closed

axl_ssl_read hangs on memory allocation failure #1615

mikee47 opened this issue Feb 10, 2019 · 2 comments
Milestone
3.8.0

Comments

@mikee47
Copy link
Contributor

mikee47 commented Feb 10, 2019

See third-party\axtls-8266\compat\lwipr_compat.c line 161. If a memory allocation fails system just hangs and we get WDT.

I would suggest better behaviour would be to free any allocated memory and return error (-1) so at least the system keeps running.

@slaff I have a proposed patch for this, but this file belongs to a sub-module of axtls so not sure of the best way to approach this.
@slaff
Copy link
Contributor

slaff commented Feb 10, 2019 •
edited
Loading

@mikee47 You can make a pull request to this repo: https://github.com/attachix/lwirax and I will take care for the rest.

@slaff slaff added this to the 3.7.2 milestone Feb 11, 2019
@slaff
Copy link
Contributor

slaff commented Feb 11, 2019

The PR request (igrr/axtls-8266#62) to axtls-8266 is created and waiting to be merged.

@slaff slaff mentioned this issue Mar 23, 2019
Merged
@slaff slaff removed the 0 - Backlog label Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
2 participants
@slaff @mikee47