Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spiffs_mount() not compatible with rBoot #1009

Closed
riban-bw opened this issue Mar 5, 2017 · 4 comments
Closed

spiffs_mount() not compatible with rBoot #1009

riban-bw opened this issue Mar 5, 2017 · 4 comments

Comments

@riban-bw
Copy link
Contributor

riban-bw commented Mar 5, 2017

I use SPIFFS in a project but when I enable rBOOT I get read errno -10011 debug output and SPIFFS is not working. I am using the configuration from Basic_rBoot Makefile-user.mk on a NodeMCU (ESP-12) module.

@riban-bw
Copy link
Contributor Author

riban-bw commented Mar 5, 2017

If I use spiffs_mount_manual(0x100000, 65536); then it works so it seems that, when building with rBoot, the automatic detection of SPIFFS location or size fails.

@slaff
Copy link
Contributor

slaff commented Mar 6, 2017

rBoot saves the SPIFF file system at a pre-defined location. Which by default is 0x100000. When you use spiffs_mount_manual(0x100000, 65536) you are instructing the SpifFS to be mounted starting from address 0x100000, which is the same one that is hard-coded.

If you use spiff_mount() is does something else - it calculates the first available sector on flash after your ROMs and looks for SpifFS starting from that sector. Which is the way non-rBoot ROMs flashing works. Since rBoot does not follow that logic you cannot expect spiffs_mount() to work for you.

That can be unified and if desired you should create a new issue and we will tackle the issue in the 3.2.0 release.

@riban-bw riban-bw changed the title rBoot + SPIFFS not working spiffs_mount() not compatible with rBoot Mar 6, 2017
@riban-bw
Copy link
Contributor Author

riban-bw commented Mar 6, 2017

I have changed the title of this issue to better reflect the problem.
Please make spiffs_mount() compatible with rBoot. There is a plan to make rBoot the default boot loader so this could / should be done to support that change. Maybe spiffs_mount() could check for rBoot and request information about spiffs from rBoot integration or a more robust and exhaustive search for the spiffs file system. It would also be advantageous for mount_spiffs() to return success indication to the application. Currently it prints to debug output but this does not allow the runtime application to deduce success.

@jochenjagers
Copy link
Contributor

I opened a pull request to solve this issue
#1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants