Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview selection should be togglable #129

Open
kaimikael opened this issue Jul 1, 2017 · 3 comments
Open

Overview selection should be togglable #129

kaimikael opened this issue Jul 1, 2017 · 3 comments

Comments

@kaimikael
Copy link
Contributor

We have an icon that zooms out the current view so that one gets all activity items in view. It would make sense if pressing the icon again brought the view back to the previous zoom level, so that one can get a quick glance at the whole and then return to the immediate surroundings.

@pjotrsavitski
Copy link
Member

That is doable. The data about current position and zoom level could easily be captured and stored temporarily. Yet it would require the icon to be changed to look somehow different to signal the user what would happen. It should also be considered how long would that be available, going back. Consider a scenario where user presses the button, the location is stored. Then user does some other things. Presses the button again, yet the functionality takes the user to the previous center position of the map and also changes the zoom level.

This enhancement should at least have an additional icon, so that the user would understand what to expect.

@kaimikael
Copy link
Contributor Author

I don't think it should reset the position, just the zoom factor. But yes, it would make sense to have a two-state icon.
I suggest that if the player has manually changed the zoom factor, that should reset the base zoom factor.

@pjotrsavitski
Copy link
Member

The current code will reset the position. The logic of the current solution is. Make sure that all the markers of the game are seen on the screen. The center of the map is no longer a user, but coordinates based on current set of points.

I could see if we could do that without changing the center of the map, but that is the way it works right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants