Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image doesn't preview when creating answer option #112

Open
PatriciaMoller opened this issue May 16, 2017 · 5 comments
Open

Image doesn't preview when creating answer option #112

PatriciaMoller opened this issue May 16, 2017 · 5 comments

Comments

@PatriciaMoller
Copy link
Collaborator

After adding a picture to an answer option for a question, the image can't been seen while editing. It can been seen after saving and if the Activity Item is edited again.

@pjotrsavitski
Copy link
Member

That one is intended, to be honest. We could show the preview of the image to be uploaded, same way as it is done during the gameplay. Does that make much sense, as the user knows which images is going to be uploaded.

Previous ones are a different matter.

@PatriciaMoller
Copy link
Collaborator Author

An instant preview is preferable. As it is now, I at first thought the picture had not been uploaded at all.

A preview, to see if the image looks good in the context, or some kind of feedback to indicate that the upload was successful would help.

@pjotrsavitski
Copy link
Member

The upload only happens later, when the form is submitted. It is not a piece-by-piece update process.

@kaimikael
Copy link
Contributor

I think this is a bit problematic. We are after all working on a game – all interaction should get as immediate feedback as possible. Instead of waiting for HTML to react to a Submit command, can we script the page to do the upload as soon as a file has been selected?

@pjotrsavitski
Copy link
Member

@kaimikael Yes, although that would require major changes to the codebase. Especially with Activity Items that have not been created yet, options that have not been stored to the DB yet. But that is doable, just need to come up with suitable logic.

One more thing is with how all the other fields behave. If only images are stored at once and all others are stored on submit, then it could be confusing.

One more approach would be to show the small preview for the newly selected image. The way that work within the Game context. That could be resource-consuming on the Browser side (needs testing to say anything for sure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants