Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misjudgment of the attribute of radioactive items #4198

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

JWJUN233233
Copy link
Contributor

@JWJUN233233 JWJUN233233 commented May 30, 2024

Description

misjudgment of the attribute of radioactive items

Proposed changes

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@JWJUN233233 JWJUN233233 requested a review from a team as a code owner May 30, 2024 00:24
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label May 30, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@JWJUN233233
Copy link
Contributor Author

caused by #3131

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 939a7201

https://preview-builds.walshy.dev/download/Slimefun/4198/939a7201

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Sfiguz7 Sfiguz7 merged commit a00e4ba into Slimefun:master Jun 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants