Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository name test fails if url contains a trailing slash #1946

Open
LennyN95 opened this issue Jun 14, 2023 · 0 comments
Open

Repository name test fails if url contains a trailing slash #1946

LennyN95 opened this issue Jun 14, 2023 · 0 comments
Labels
Type: Bug Something's not working correctly.

Comments

@LennyN95
Copy link
Contributor

The folowing test line fails if the url ends with a trailing '/'.

https://github.com/Slicer/ExtensionsIndex/blob/466d0f864072966f730d5f2d9c357a16c213c284/scripts/check_description_files.py#LL84C5-L84C95

I'd suggest we either remove trailing slashes or, if trailing slashes are discouraged, we could implement a check and fail with a meaningful message, because the current one suggests the repository name is empty which could be misleading.

@jcfr jcfr added the Type: Bug Something's not working correctly. label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something's not working correctly.
Development

No branches or pull requests

2 participants