Docs for SKStore #246
Open
Docs for SKStore #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbouaziz
reviewed
Jun 20, 2024
Comment on lines
+38
to
+42
| myInputDirectory.writeArray(context, myKey, Array[myValue]) | ||
| ``` | ||
|
|
||
| Removing an element just consists in writing an empty array (also | ||
| called a "tomb"). There is no sematic difference between an empty |
There was a problem hiding this comment.
Two things here:
- one way wonder why you may associate arrays only, not any type of values and arrays would be a special case (There is no sematic difference between an empty array and no entry gives a hint)
- it's not obvious that
writeArrayis replacing and not appending (Removing an element just consists in writing an empty array gives a hint as well)
| (context, writer, key, fileIterator) ~> { | ||
| values = mutable Vector[]; | ||
| for(file in fileIterator) { | ||
| value = myOtherDirectory.getArray(SID::create(file.value)); |
There was a problem hiding this comment.
Suggested change
| value = myOtherDirectory.getArray(SID::create(file.value)); | |
| value = myOtherDirectory.getArray(context, SID::create(file.value)); |
It is worth noting that this automatically records the dependency
There was a problem hiding this comment.
And the granularity of the dep record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to describe SKStore. Still needs some work.