-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some old jpg images are saved with glitches (regression in alpha) #1978
Comments
Can confirm on my machine. Will work on it asap. |
I've found error leading to this. It was broken in #1694 which did spectral -> color conversion withing spectral strides instead of full image. Everything does work in current tests because we don't have a single component jpeg with non 1x1 sampling factors in current test suite. ITU spec says that any single component jpeg must be decoded as 'non-interleaved' jpeg:
Current decoder implementation decodes single-component jpegs int interleaved mode and it works for 1x1/2x1/4x1 sampling jpegs but vertical sampling factors break it due to interleaved 'traversal': Fix should be fairly simple, will try to create a PR today. P.S. |
@br3aker Thank you very much for such a quick response! Sure, you can use it for your tests. |
@botinko thanks! Fix is ready and should be available in the nearest nightly build after merge, thanks for pointing this one :) |
Prerequisites
DEBUG
andRELEASE
modeDescription
Some pictures of our clients get corrupted when resizing and even when simply resaving by ImageSharp.
Issue exists in
2.0.0-alpha.0.168
but doesn't exists inv1.0.4
.Steps to Reproduce
before
after
Link to original image and image after resaving https://drive.google.com/file/d/1_k54RFuPciKeKBtFDLftIKetOPsWkOFO/view?usp=sharing
If you resave the image in any editor, the problem stops reproducing. So you need an original image from archive to reproduce.
System Configuration
The text was updated successfully, but these errors were encountered: