From 224265d5df35b04a85ae9f35e0943553df42e49f Mon Sep 17 00:00:00 2001
From: elenamongelli <52746406+elenamongelli@users.noreply.github.com>
Date: Fri, 7 May 2021 16:26:14 +0200
Subject: [PATCH 1/5] Pass tests for R12 implemented, starting with failed

---
 .../alfa-rules/test/sia-r12/rule.spec.tsx     | 56 +++++++++++++++++++
 packages/alfa-rules/tsconfig.json             |  1 +
 2 files changed, 57 insertions(+)
 create mode 100644 packages/alfa-rules/test/sia-r12/rule.spec.tsx

diff --git a/packages/alfa-rules/test/sia-r12/rule.spec.tsx b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
new file mode 100644
index 0000000000..a0da7a0952
--- /dev/null
+++ b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
@@ -0,0 +1,56 @@
+import { test } from "@siteimprove/alfa-test";
+
+import { Document } from "@siteimprove/alfa-dom";
+
+import R12, { Outcomes } from "../../src/sia-r12/rule";
+
+import { evaluate } from "../common/evaluate";
+import { passed, failed, inapplicable } from "../common/outcome";
+
+test(`evaluates() passes a <button> with accessible name `, async (t) => {
+  const target = <button>My button</button>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [
+    passed(R12, target, {
+      1: Outcomes.HasName,
+    }),
+  ]);
+});
+
+test(`evaluates() passes an input element with accessible value attribute `, async (t) => {
+  const input = <input type="submit" value="Submit" />;
+
+  const document = Document.of([input]);
+
+  t.deepEqual(await evaluate(R12, { document }), [
+    passed(R12, input, {
+      1: Outcomes.HasName,
+    }),
+  ]);
+});
+
+test(`evaluates() passes a <button> with aria label attribute`, async (t) => {
+  const target = <button aria-label="My button"></button>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [
+    passed(R12, target, {
+      1: Outcomes.HasName,
+    }),
+  ]);
+});
+
+test(`evaluates() fails <button> with no attribute`, async (t) => {
+  const target = <button></button>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [
+    failed(R12, target, {
+      1: Outcomes.HasNoName,
+    }),
+  ]);
+});
diff --git a/packages/alfa-rules/tsconfig.json b/packages/alfa-rules/tsconfig.json
index e94faed657..73829bc9e9 100644
--- a/packages/alfa-rules/tsconfig.json
+++ b/packages/alfa-rules/tsconfig.json
@@ -161,6 +161,7 @@
     "test/sia-r9/rule.spec.tsx",
     "test/sia-r10/rule.spec.tsx",
     "test/sia-r11/rule.spec.tsx",
+    "test/sia-r12/rule.spec.tsx",
     "test/sia-r13/rule.spec.tsx",
     "test/sia-r14/rule.spec.tsx",
     "test/sia-r15/rule.spec.tsx",

From 96041c2d5eaca2a8b87c7bd9aba35f494a5fa496 Mon Sep 17 00:00:00 2001
From: elenamongelli <52746406+elenamongelli@users.noreply.github.com>
Date: Tue, 11 May 2021 12:30:46 +0200
Subject: [PATCH 2/5] Update rule.spec.tsx

---
 .../alfa-rules/test/sia-r12/rule.spec.tsx     | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/packages/alfa-rules/test/sia-r12/rule.spec.tsx b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
index a0da7a0952..891ba3914d 100644
--- a/packages/alfa-rules/test/sia-r12/rule.spec.tsx
+++ b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
@@ -54,3 +54,39 @@ test(`evaluates() fails <button> with no attribute`, async (t) => {
     }),
   ]);
 });
+
+test(`evaluates() fails <button> element with no accessible name`, async (t) => {
+  const target = <button type="button" value="read more"></button>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [
+    failed(R12, target, {
+      1: Outcomes.HasNoName,
+    }),
+  ]);
+});
+
+test(`evaluates() fails element with <button> role because it doesn't have a content with accessible name`, async (t) => {
+  const target = <span role="button"></span>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [
+    failed(R12, target, {
+      1: Outcomes.HasNoName,
+    }),
+  ]);
+});
+
+test(`evaluates() fails element with <button> role because it doesn't have a content with accessible name`, async (t) => {
+  const target = <span role="button"></span>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [
+    failed(R12, target, {
+      1: Outcomes.HasNoName,
+    }),
+  ]);
+});

From c9518ebc6be0d43e8ad8a7376ed571a3b64c4244 Mon Sep 17 00:00:00 2001
From: elenamongelli <52746406+elenamongelli@users.noreply.github.com>
Date: Tue, 11 May 2021 12:46:47 +0200
Subject: [PATCH 3/5] Test rule 12 finished

---
 .../alfa-rules/test/sia-r12/rule.spec.tsx     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/packages/alfa-rules/test/sia-r12/rule.spec.tsx b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
index 891ba3914d..5792d4aadd 100644
--- a/packages/alfa-rules/test/sia-r12/rule.spec.tsx
+++ b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
@@ -90,3 +90,35 @@ test(`evaluates() fails element with <button> role because it doesn't have a con
     }),
   ]);
 });
+
+test(`evaluate() is inapplicabile to input element with image attribute`, async (t) => {
+  const target = <input type="image" value="download" alt="Download" />;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [inapplicable(R12)]);
+});
+
+test(`evaluate() is inapplicabile to input element with image attribute`, async (t) => {
+  const target = <input type="image" value="download" alt="Download" />;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [inapplicable(R12)]);
+});
+
+test(`evaluate() is inapplicabile to element with no button role`, async (t) => {
+  const target = <div>Press Here</div>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [inapplicable(R12)]);
+});
+
+test(`evaluate() is inapplicabile to button element with none role`, async (t) => {
+  const target = <button role="none" disabled></button>;
+
+  const document = Document.of([target]);
+
+  t.deepEqual(await evaluate(R12, { document }), [inapplicable(R12)]);
+});

From a561f378b2f7d355ceb1a42c6e203776de46f328 Mon Sep 17 00:00:00 2001
From: elenamongelli <52746406+elenamongelli@users.noreply.github.com>
Date: Tue, 11 May 2021 14:43:56 +0200
Subject: [PATCH 4/5] Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
---
 .../alfa-rules/test/sia-r12/rule.spec.tsx     | 39 +++----------------
 1 file changed, 5 insertions(+), 34 deletions(-)

diff --git a/packages/alfa-rules/test/sia-r12/rule.spec.tsx b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
index 5792d4aadd..237cf3720c 100644
--- a/packages/alfa-rules/test/sia-r12/rule.spec.tsx
+++ b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
@@ -19,7 +19,7 @@ test(`evaluates() passes a <button> with accessible name `, async (t) => {
   ]);
 });
 
-test(`evaluates() passes an input element with accessible value attribute `, async (t) => {
+test(`evaluates() passes a submit button element with an accessible name given by the value attribute `, async (t) => {
   const input = <input type="submit" value="Submit" />;
 
   const document = Document.of([input]);
@@ -31,7 +31,7 @@ test(`evaluates() passes an input element with accessible value attribute `, asy
   ]);
 });
 
-test(`evaluates() passes a <button> with aria label attribute`, async (t) => {
+test(`evaluates() passes a <button> with a name given by the \`aria-label\` attribute`, async (t) => {
   const target = <button aria-label="My button"></button>;
 
   const document = Document.of([target]);
@@ -43,7 +43,7 @@ test(`evaluates() passes a <button> with aria label attribute`, async (t) => {
   ]);
 });
 
-test(`evaluates() fails <button> with no attribute`, async (t) => {
+test(`evaluates() fails a button with no accessible name`, async (t) => {
   const target = <button></button>;
 
   const document = Document.of([target]);
@@ -55,19 +55,8 @@ test(`evaluates() fails <button> with no attribute`, async (t) => {
   ]);
 });
 
-test(`evaluates() fails <button> element with no accessible name`, async (t) => {
-  const target = <button type="button" value="read more"></button>;
 
-  const document = Document.of([target]);
-
-  t.deepEqual(await evaluate(R12, { document }), [
-    failed(R12, target, {
-      1: Outcomes.HasNoName,
-    }),
-  ]);
-});
-
-test(`evaluates() fails element with <button> role because it doesn't have a content with accessible name`, async (t) => {
+test(`evaluates() fails an element with \`button\` role because and without an accessible name`, async (t) => {
   const target = <span role="button"></span>;
 
   const document = Document.of([target]);
@@ -79,19 +68,8 @@ test(`evaluates() fails element with <button> role because it doesn't have a con
   ]);
 });
 
-test(`evaluates() fails element with <button> role because it doesn't have a content with accessible name`, async (t) => {
-  const target = <span role="button"></span>;
-
-  const document = Document.of([target]);
 
-  t.deepEqual(await evaluate(R12, { document }), [
-    failed(R12, target, {
-      1: Outcomes.HasNoName,
-    }),
-  ]);
-});
-
-test(`evaluate() is inapplicabile to input element with image attribute`, async (t) => {
+test(`evaluate() is inapplicable to image buttons`, async (t) => {
   const target = <input type="image" value="download" alt="Download" />;
 
   const document = Document.of([target]);
@@ -99,13 +77,6 @@ test(`evaluate() is inapplicabile to input element with image attribute`, async
   t.deepEqual(await evaluate(R12, { document }), [inapplicable(R12)]);
 });
 
-test(`evaluate() is inapplicabile to input element with image attribute`, async (t) => {
-  const target = <input type="image" value="download" alt="Download" />;
-
-  const document = Document.of([target]);
-
-  t.deepEqual(await evaluate(R12, { document }), [inapplicable(R12)]);
-});
 
 test(`evaluate() is inapplicabile to element with no button role`, async (t) => {
   const target = <div>Press Here</div>;

From f03a709781faf9ed9fd159b49b3bf6baf29187dd Mon Sep 17 00:00:00 2001
From: elenamongelli <52746406+elenamongelli@users.noreply.github.com>
Date: Tue, 11 May 2021 14:46:27 +0200
Subject: [PATCH 5/5] Text sintax improved

---
 packages/alfa-rules/test/sia-r12/rule.spec.tsx | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/alfa-rules/test/sia-r12/rule.spec.tsx b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
index 237cf3720c..a3de061309 100644
--- a/packages/alfa-rules/test/sia-r12/rule.spec.tsx
+++ b/packages/alfa-rules/test/sia-r12/rule.spec.tsx
@@ -55,8 +55,7 @@ test(`evaluates() fails a button with no accessible name`, async (t) => {
   ]);
 });
 
-
-test(`evaluates() fails an element with \`button\` role because and without an accessible name`, async (t) => {
+test(`evaluates() fails an element with \`button\` role without an accessible name`, async (t) => {
   const target = <span role="button"></span>;
 
   const document = Document.of([target]);
@@ -68,7 +67,6 @@ test(`evaluates() fails an element with \`button\` role because and without an a
   ]);
 });
 
-
 test(`evaluate() is inapplicable to image buttons`, async (t) => {
   const target = <input type="image" value="download" alt="Download" />;
 
@@ -77,7 +75,6 @@ test(`evaluate() is inapplicable to image buttons`, async (t) => {
   t.deepEqual(await evaluate(R12, { document }), [inapplicable(R12)]);
 });
 
-
 test(`evaluate() is inapplicabile to element with no button role`, async (t) => {
   const target = <div>Press Here</div>;