Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate accessible name fallback after valid but empty aria-labelledby #389

Closed
Jym77 opened this issue Sep 16, 2020 · 3 comments
Closed
Labels
Research Task that need some investigation and experiment

Comments

@Jym77
Copy link
Contributor

Jym77 commented Sep 16, 2020

https://act-rules.github.io/rules/ffd0e9#failed-example-1

<span id="label"></span>
<h1 aria-labelledby="label">ACT rules</h1>

The IDref does exist but when processing it for name results in an empty name.
It is not fully clear in the specs that step 2B should continue in that case (if the IDref exists, it is processed and returned, comparatively step 2C is explicit about aria-label not being empty).

In our current implementation, that step returns an empty value and fromSteps thus continue to the next step.
See also act-rules/act-rules.github.io#1203

(looks like with the previous implementation of accessible name, we did exit early in that case)

@Jym77 Jym77 added the bug Report of unexpected or faulty behaviour in Alfa label Sep 16, 2020
@kasperisager kasperisager removed the bug Report of unexpected or faulty behaviour in Alfa label Sep 16, 2020
@kasperisager
Copy link
Contributor

The current behaviour aligns with Firefox and Safari so Chrome seems like the odd one out. Let's keep an eye on w3c/accname#72.

@kasperisager kasperisager changed the title Investigate accessible name fallback after valid but empty aria-labelledby Investigate accessible name fallback after valid but empty aria-labelledby Sep 16, 2020
@kasperisager
Copy link
Contributor

I opened w3c/accname#112 to solve this, which may or may not be accepted 🤷

@Jym77 Jym77 added the Research Task that need some investigation and experiment label Feb 14, 2022
@Jym77
Copy link
Contributor Author

Jym77 commented Jul 18, 2022

With the clarification at w3c/html-aam#414 (comment) it seems that empty strings should indeed be rejected and computation goes to next step. Since this is our behaviour, we can close this.

@Jym77 Jym77 closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Research Task that need some investigation and experiment
Projects
None yet
Development

No branches or pull requests

2 participants