Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19, add test case #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nicolaiunrein
Copy link

@nicolaiunrein nicolaiunrein commented May 17, 2021

This PR fixes #19.
I Modified the clone method so that it also copies the fields _captureNames and _implodeString. If it does not make sense to add the _implodeString field feel free to remove it. I just looked at the code briefly in order to resolve #19 as I ran into the same problem myself and needed it to be fixed.

@codecov-commenter
Copy link

Codecov Report

Merging #20 (c5f640c) into master (79a8fd1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c5f640c differs from pull request most recent head a313f8e. Consider uploading reports for the commit a313f8e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   96.83%   96.84%   +0.01%     
==========================================
  Files          19       19              
  Lines         505      507       +2     
  Branches       73       73              
==========================================
+ Hits          489      491       +2     
  Misses         16       16              
Impacted Files Coverage Δ
lib/Builder.js 97.08% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a8fd1...a313f8e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"_captureNames" is not saved in the internal Cache system
2 participants