Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional dictionary file. #6

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Update additional dictionary file. #6

merged 1 commit into from
Jan 12, 2023

Conversation

zivy
Copy link
Member

@zivy zivy commented Jan 12, 2023

Added GDCMSeriesIDs to the dictionary.

Added GDCMSeriesIDs to the dictionary.
@zivy zivy requested a review from dave3d January 12, 2023 20:40
@zivy
Copy link
Member Author

zivy commented Jan 12, 2023

Should the additional_dictionary.txt file be moved to the repository which uses the spell checking?

That way each repository has its own small "additional dictionary" vs. one mega dictionary. Not sure about this as I think the SimpleITK main repo is the only one using this code, but maybe not.

@zivy zivy requested a review from blowekamp January 12, 2023 20:45
@blowekamp
Copy link
Member

@zivy I think that is a good idea. At some point I worked on making a pyproject.toml file for this project to be installable, but ran into a problem with including data, i.e. the additional dictionary.

@zivy zivy merged commit cd73a02 into main Jan 12, 2023
@zivy zivy deleted the updateDictionary branch January 12, 2023 20:57
@blowekamp
Copy link
Member

@zivy It looks like it can already be done with the -dict flag: https://github.com/SimpleITK/SimpleITKSpellChecking/blob/main/codespell.py#L161-L163

@zivy
Copy link
Member Author

zivy commented Jan 12, 2023

@blowekamp Where should the additional dictionary go in the main SimpleITK repo? Looking at the directory structure possibly add it under Utilities?

@blowekamp
Copy link
Member

Or in .github/workflows?

@zivy
Copy link
Member Author

zivy commented Jan 12, 2023

Much better (why didn't I think of that 😃), see PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants