BUG: Remove unused test when setting suffixes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jcfr
force-pushed
the
tweak-suffix-handling
branch
3 times, most recently
from
6486539
to
ade050d
Compare
|
@dave3d This is ready for review and integration. Thanks for your time 🙏 |
This commit partially reverts 775776e (ENH: Initialize default list of suffixes) removing unused test when setting the suffix variable. It also ensures there are no duplicated prefixes.
jcfr
force-pushed
the
tweak-suffix-handling
branch
from
ade050d
to
9bbf1e0
Compare
dave3d
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts 775776e (ENH: Initialize default list of suffixes) removing unused test when setting the suffix variable.
It also ensures there are no duplicated prefixes.