Add Levenberg-Marquardt model calibration

[richterjakob]

No description provided.

[menon-karthik]

Update: I think I got the interface and coupling to svSolver to work now. I have also created a simple C++ test case for the interface while doing this, which should be added to the github actions (#30 ). Still wondering what would be the best way to add a test case specifically for the svSolver (and eventually svFSIPlus) coupling.

One issue I'm having is running the test cases when I build the code using CMake instead of pip (on Sherlock). In this case, pytest cannot find the svzerodplus package that is required to run tests/test_integration_cpp.py. Is there a way to have this work when using the CMake installation?

I will push my changes in the next few days!

[menon-karthik]

Looks great to me for the most part! The only problem is pytest not working when using the CMake build on Sherlock.

[richterjakob]

One issue I'm having is running the test cases when I build the code using CMake instead of pip (on Sherlock). In this case, pytest cannot find the svzerodplus package that is required to run tests/test_integration_cpp.py. Is there a way to have this work when using the CMake installation?

Unfortunately the python interface (which pytest is using) only works when installing svZeroDPlus via pip. But the pip installation should work on brocken.

[mrp089]

Thanks for adding the test, @richterjakob! I'll move the cali.py script to a repository for the upcoming paper.

[richterjakob]

Thanks for adding the test, @richterjakob! I'll move the cali.py script to a repository for the upcoming paper.

Haha, you were faster than I could type that the only thing left is to decide whether keeping cali.py in this repository is the right choice 😄

[richterjakob]

But otherwise I think we are ready to merge, right?

[menon-karthik]

One issue I'm having is running the test cases when I build the code using CMake instead of pip (on Sherlock). In this case, pytest cannot find the svzerodplus package that is required to run tests/test_integration_cpp.py. Is there a way to have this work when using the CMake installation?

Unfortunately the python interface (which pytest is using) only works when installing svZeroDPlus via pip. But the pip installation should work on brocken.

In that case, one last thing I need to do is test the pip installation and pytest on Sherlock. If that doesn't work, it's not huge deal because people pushing from Sherlock can still use Github actions in their own branches to run the tests. But I will add a note in the documentation if that is the case. I should have this done this morning.

If there's nothing else to add (apart from moving the cali.py script), I can merge after I test that. Does that sound good @richterjakob and @mrp089 ?

[richterjakob]

One issue I'm having is running the test cases when I build the code using CMake instead of pip (on Sherlock). In this case, pytest cannot find the svzerodplus package that is required to run tests/test_integration_cpp.py. Is there a way to have this work when using the CMake installation?

Unfortunately the python interface (which pytest is using) only works when installing svZeroDPlus via pip. But the pip installation should work on brocken.

In that case, one last thing I need to do is test the pip installation and pytest on Sherlock. If that doesn't work, it's not huge deal because people pushing from Sherlock can still use Github actions in their own branches to run the tests. But I will add a note in the documentation if that is the case. I should have this done this morning.

If there's nothing else to add (apart from moving the cali.py script), I can merge after I test that. Does that sound good @richterjakob and @mrp089 ?

I tested the build on Sherlock already and it worked without problems.

If that's okay, I would like to do the honour of merging this 😁