Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code coverage and parametrization of solver tests #118

Merged
merged 19 commits into from
Jul 31, 2024

Conversation

ncdorn
Copy link
Contributor

@ncdorn ncdorn commented Jul 29, 2024

improve code coverage and parametrization of solver tests

Current situation

Currently, the pytest solution does not explicitly tell you which case is failing. Additionally, code coverage has dropped (see #117) since the last pull request I made addressing #95

Release Notes

  • parameterize solver tests to determine which test case is failing
  • updated solver test to increase code coverage

Documentation

Please ensure that you properly document any additions.

Testing

Please ensure that the PR meets the testing requirements set by GitHub Actions.

In addition, please ensure all modified and new code is covered by tests.

Code of Conduct & Contributing Guidelines

@menon-karthik menon-karthik self-requested a review July 29, 2024 20:34
@menon-karthik menon-karthik linked an issue Jul 31, 2024 that may be closed by this pull request
1 task
Copy link
Member

@menon-karthik menon-karthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ncdorn!

@menon-karthik menon-karthik merged commit 5d3bf35 into SimVascular:master Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop in coverage
2 participants