-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wi-Fi] Enabled both the buttons for 917SoC 2.0 boards #141
[Wi-Fi] Enabled both the buttons for 917SoC 2.0 boards #141
Conversation
5faaede
to
b0ed689
Compare
b0ed689
to
395d9dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the folder to BRD43xxx to accommodate the fact of using the same files with BRD4338A
Team unable to do that since a EFR32 board also have BRD43xxx, moved to maintaining BRD4338A for now |
Does this replace the file rsi_hal_mcu_m4.c in examples/platform/silabs/SiWx917/SiWx917/hal/ ? If so, shouldn't this file be added there? |
hi @mykrupp we are using the file rsi_hal_mcu_m4.c from mtter_support (moved the file to matter support while integrating wifi-sdk based on Jean's suggestion). We no longer use the file that is there in examples/platform/silabs/SiWx917/SiWx917/hal/ |
OK, can the file from examples/platform/silabs/SiWx917 be deleted then in a follow up PR? |
yes, can be deleted. |
Created a draft PR with the changes required in CSA master project-chip/connectedhomeip#29055