Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wi-Fi] Enabled both the buttons for 917SoC 2.0 boards #141

Merged

Conversation

silabs-srishylam
Copy link
Collaborator

@silabs-srishylam silabs-srishylam commented Aug 28, 2023

  • Added BRD4338A folder
  • Configured GPIO_11 for BTN1 and added the interrupt handler (IRQ059_Handler)
  • Configured GPIO_2 for BTN0 and added the interrupt handler (IRQ021_Handler)

Created a draft PR with the changes required in CSA master project-chip/connectedhomeip#29055

@rosahay-silabs rosahay-silabs force-pushed the wifi_917soc_2.0_enabling_button branch from b0ed689 to 395d9dc Compare September 1, 2023 08:47
Copy link
Collaborator

@rosahay-silabs rosahay-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the folder to BRD43xxx to accommodate the fact of using the same files with BRD4338A

@rosahay-silabs
Copy link
Collaborator

rename the folder to BRD43xxx to accommodate the fact of using the same files with BRD4338A

Team unable to do that since a EFR32 board also have BRD43xxx, moved to maintaining BRD4338A for now

@mykrupp
Copy link
Collaborator

mykrupp commented Sep 6, 2023

Does this replace the file rsi_hal_mcu_m4.c in examples/platform/silabs/SiWx917/SiWx917/hal/ ? If so, shouldn't this file be added there?

@silabs-srishylam
Copy link
Collaborator Author

Does this replace the file rsi_hal_mcu_m4.c in examples/platform/silabs/SiWx917/SiWx917/hal/ ? If so, shouldn't this file be added there?

hi @mykrupp we are using the file rsi_hal_mcu_m4.c from mtter_support (moved the file to matter support while integrating wifi-sdk based on Jean's suggestion). We no longer use the file that is there in examples/platform/silabs/SiWx917/SiWx917/hal/

@mykrupp
Copy link
Collaborator

mykrupp commented Sep 8, 2023

OK, can the file from examples/platform/silabs/SiWx917 be deleted then in a follow up PR?

@silabs-srishylam
Copy link
Collaborator Author

OK, can the file from examples/platform/silabs/SiWx917 be deleted then in a follow up PR?

yes, can be deleted.

@selissia selissia merged commit 32535c9 into SiliconLabs:main Sep 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants