Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #4073

Closed
wants to merge 3 commits into from
Closed

Master #4073

wants to merge 3 commits into from

Conversation

nbardy
Copy link

@nbardy nbardy commented May 10, 2023

Background

Found a bug when this key was missing

Changes

Adds a None check

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 11:52am

@github-actions github-actions bot added size/m and removed size/s labels May 10, 2023
@vercel vercel bot temporarily deployed to Preview May 10, 2023 11:52 Inactive
try:
content_dict = json.loads(event["content"])
except json.JSONDecodeError:
print(f"Error: Invalid JSON string in event['content']: {event['content']}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the print to a debug log.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 12, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@k-boikov
Copy link
Contributor

Fixed with #3996

@k-boikov k-boikov closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants